Comment 13 for bug 1845460

Revision history for this message
Wayne Stambaugh (stambaughw) wrote : Re: [Bug 1845460] Re: Find (Ctrl-F) loop at end of results

On 11/27/19 5:02 AM, Novak Tamas wrote:
> - markers: I've asked for omitting DRC markers from search, as I can't
> see any reason for it. I check markers visually while eliminating them;
> never felt for searching them, and can't see *any* purpose to do that..

I strongly disagree with this opinion. Why should I have to close one
dialog and open another dialog to find a different board object with
searchable text? One thing I've always like about KiCad is that things
can be done with the minimum amount extra steps. Searching for DRC
markers using the find dialog string filtering is a perfectly valid
operation. If you personally feel the need to exit the find dialog and
open the DRC dialog, that's fine but don't force that paradigm on the
rest of us. Before this patch will be accepted, the DRC marker
searching needs to be reinstated. You can implement it with a simple
checkbox "Include DRC markers" if you prefer that over a separate DRC
marker search button.

>
> - "Search again": "Restart search" for button text is more accurate.
>
> - "Word" and "Wildcard" aren't the same (but inverted) option? When Word
> if ticked, searchnig for "1k" won't find "1k5". If "Word" is off, it
> will find "R123" when looking for "R1". How searching would behave when
> both "Word" and "Wildcard" is off?

The * and ? characters are searched as is instead of used for wildcard
expansion the same as any other search. If word and wildcard are off,
"U?" would find "U?A" and "U?B" but not "U1A". You can use '*' as the
same as disabling the word option but they are not mutually exclusive.

>
> - XY order: it seems results are sorted now (descending REF...or it is a
> natural stored order, so no sorting?) XY location order would go to the
> wishlist if not going to be implemented now.
>