LibEdit Pin properties tab order incorrect

[Seth Hillbrand]

Creating a new pin in libedit, the first field selected is the pin name. Pressing tab moves through the text fields first before moving back to the drop-down items.

Tab should move in visual order between the items.

Application: LibEdit
Version: (5.1.0-1574-g22fdc7f51-dirty), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.64.0 OpenSSL/1.1.1c zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) libssh2/1.8.0 nghttp2/1.36.0 librtmp/2.3
Platform: Linux 4.19.0-5-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.67.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.64.0
    Compiler: GCC 8.3.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
    KICAD_STDLIB_DEBUG=OFF
    KICAD_STDLIB_LIGHT_DEBUG=OFF
    KICAD_SANITIZE=OFF

[Wayne Stambaugh (stambaughw)]

@Jeff, if you fix the tab order problem, you will break the mnemonics. See bug report https://bugs.launchpad.net/kicad/+bug/1818930 and commit https://git.launchpad.net/kicad/patch/?id=92fe201c5bbdcfb57aa5f22a865d3c194f0e0b7d. I'm not sure you will be able to find a solution to both problems. I'm fine with dumping the mnemonics and having a correct tab order.

[Jeff Young (jeyjey)]

@Wayne, could you check to see if I broke the mnemonics? I suspect that the tab order and the results of the creation order are the same, but maybe wxWidgets has separate data structures.

(There's no way to get mnemonics on Mac is there?)

[KiCad Janitor (kicad-janitor)]

Fixed in revision 13b7dd354c9860b9556170b5281c07b1ae5c4964
https://git.launchpad.net/kicad/patch/?id=13b7dd354c9860b9556170b5281c07b1ae5c4964

[Wayne Stambaugh (stambaughw)]

Your patch breaks mnemonics for all of the controls in the left grid bag sizer. The tab order works nicely though. I'm not sure what the solution is but neither mine nor yours solves all of the issues. Anyone else know how to solve this one without breaking something else?

[Jeff Young (jeyjey)]

Yeah, that was certainly my suspicion.

Do we know if a later version of wxWidgets fixes the mnemonic issue?

[Wayne Stambaugh (stambaughw)]

I haven't tested this with the 3.1 branch of wxWidgets. I will try to find some time this weekend to test it.

[Jeff Young (jeyjey)]

@Wayne, I've pushed new bits for you to try out.

Cheers,
Jeff.

[KiCad Janitor (kicad-janitor)]

Fixed in revision c85d1fa00c87b29055b448bff0369a58b47c9490
https://git.launchpad.net/kicad/patch/?id=c85d1fa00c87b29055b448bff0369a58b47c9490

[Wayne Stambaugh (stambaughw)]

@Jeff, nice fix. The mnemonics now seem to work as expected. One thing that you forgot in your tab ordering fix that I missed is adding the check boxes and dialog buttons to the tab ordering list. Currently tabbing ends with the number text size edit control and loops back to the pin name edit control.

[Jeff Young (jeyjey)]

Hmm... that's going to take a bit more code. Mac only allows tabbing between text fields.

[Jeff Young (jeyjey)]

@Wayne, new bits pushed. Works on Mac, but I can't guarantee anything about MSW. ;)

[Wayne Stambaugh (stambaughw)]

@Jeff, I just tested this on MSW and everything seems to be working except the dialog buttons. Tabbing to the dialog buttons seems to work in most the other dialogs.

[Jeff Young (jeyjey)]

@Wayne, if you could test it one more time just to make sure SetFocus() also works for buttons on MSW.

[Wayne Stambaugh (stambaughw)]

@Jeff, everything seems to be in order now. Thanks for fixing this!