Alt+O doesn't confirm in Pin Properties Dialogue Box

[George Brown]

While adding or editing a symbol pin in eeschema the "Pin Properties" dialogue box is shown. Most dialogue boxes in KiCad bind Alt+O to "OK". In this box however Alt+O binds to the orientation drop down as well as the OK button. Consequently using that shortcut does nothing.

Not sure if there is a "style guide" of sorts for this, but it would seem to move the orientation bind to another letter.

Thank you!

Checked this in the current nightly and the latest stable in Ubuntu 18.04, using the PPAs.
Nightly: Version: 5.1.0-rc2-unknown-4612175~94~ubuntu18.04.1, release build
Stable: Version: 5.0.2-bee76a0~70~ubuntu18.04.1, release build

[John Beard (john-j-beard)]

I think it makes sense to have a convention to reserve "O" and "C" for OK and Cancel for the sake of consistency. Orientation can use "R".

This is a string change, so it'll have to wait now until v6 opens.

Other issues in the dialog that should be hit at the same time:

* Graphic style, X pos, Y pos, Pin length, all do not have Alt accelerators
* Accelerators for most text/drop down don't work, or select the wrong one (Eg Alt-E selects "X pos")

In the meantime, Enter/Esc do OK/Cancel as normal.

[Michael Kavanagh (michaelkavanagh)]

Something like this?

[Wayne Stambaugh (stambaughw)]

@Michael, your patch doesn't seem to work on windows. Alt-R moves the cursor to the "Pin length" edit control rather than the "Orientation" combobox control. I suppose it fixes the duplicate mnemonic issue.

[Michael Kavanagh (michaelkavanagh)]

@Wayne, dang. Admittedly it was a shot in the dark since macOS doesn't have mnemonics, so I can't reproduce it anyway. Does adding a new mnemonic to the next control (Pin length) help?

[Wayne Stambaugh (stambaughw)]

@Michael, nope. I already tried that as well as giving all of the static text unique mnemonics and changing all of the control and static text IDs to wxID_ANY. It appears there is bug in wxBitmapComboBox that prevents the control from being selected when the static text mnemonic is pressed. I will give a try on Linux to see if the behavior is any different.

[Wayne Stambaugh (stambaughw)]

I spent over half day trying to figure this out and I think I know what is going on. If the combobox type wxCB_READONLY and the units static text controls are removed the mnemonics work as expected. In order to resolve this issue, I had to move all of the edit controls and their associated mnemonic static text controls before all of the read only comboboxes and units static text controls and it seems to work as expected (at least on linux). This doesn't change the position of the controls in the sizer. It only changes the order in which objects are added to the sizer which appears to be the correct solution. I'm guessing there are a lot of other dialogs with broken mnemonic dialog behavior.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 92fe201c5bbdcfb57aa5f22a865d3c194f0e0b7d
https://git.launchpad.net/kicad/patch/?id=92fe201c5bbdcfb57aa5f22a865d3c194f0e0b7d