Comment 22 for bug 1838448

I'm able to turn off the "-Wp,-D_GLIBCXX_ASSERTIONS" by overriding the "__global_compiler_flags" macro that the Fedora build-system uses. I added the following line to the Fedora spec file:

%define __global_compiler_flags -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong -grecord-gcc-switches %{_hardened_cflags} %{_annotated_cflags}

It is a bit ugly, because if Fedora ever changes the "__global_compiler_flags" macro, we will be out of sync with the rest of Fedora. Also, since that macro includes other macros, things could break badly. I'll try to keep an eye out for that.

I started the Fedora builds, but it will be a week or more before they become available, owing to the Fedora Karma requirements. If enough people test, the builds could pop out sooner, but historically that doesn't happen, so we will likely have to incur the 1 week Karma penalty.

I'm not sure if this change is also wanted for the nightly builds. Since those are debug builds, I don't think we want the change there, but please tell me if they should be changed too.

One thing bothers me - if the Fedora build had not crashed on @Rene, the underlying VRML bug would have gone unnoticed. That makes me wonder if we should really be adding "-Wp,-D_GLIBCXX_ASSERTIONS" to all the other builds (like Mac and Windows) rather than removing it from Fedora. Wasn't discovering the VRML bug a good thing?