Comment 4 for bug 1836498

Revision history for this message
Ian McInerney (imcinerney) wrote :

So, after some digging it appears this issue is both inside wxWidgets and also affects more than just the save dialog box. First of all, it appears to be a GTK-only issue. From what I gather the problem is that the wxStaticText objects are not being resized properly when the font is converted to bold face after creation [1], [2] due to a change in how GTK processes sizing updates. The way wxWidgets responded to that change is to fire a EVT_SIZE event on font change, and then make the user redo the sizing in a handler [3]-[4].

As mentioned, this affects more than just the save windows. Looking into the About window, it is clear some text is being cutoff (see the new attached image where the cateogry labels should have the text "by:" on the end).

The fix for the save dialog is fairly simple, but I have not figured out a good way of patching all the other text objects that display this issue. Another thing I found was that if the text is changed, the objects don't seem to resize either. I don't know if we change any text inside the wxStaticText objects, but that could also be an issue on GTK.

TLDR: GTK + Bold static text = text cutoff everywhere

[1] https://trac.wxwidgets.org/ticket/16088
[2] https://forums.wxwidgets.org/viewtopic.php?t=42515
[3] https://github.com/wxWidgets/wxWidgets/commit/101c43d0aa703a843f177c449fad73951de199c3
[4] https://github.com/wxWidgets/wxWidgets/commit/3b4ee5a031b1c2fa29772b90751a82dd7f1d3de0