Comment 5 for bug 1832595

Revision history for this message
Ian McInerney (imcinerney) wrote :

@Seth, since I am touching the dialog anyway to add in the unit option for export we could update the tooltip at the same time (also since this dialog was made with form builder, any commit with it is going to be horrendous so this would consolidate things into 1 huge commit). That would push the change into 5.1.3.

Looking at the code that references that option, the reference to polygons probably is because one branch calls the function "ConvertBrdLayerToPolygonalContours" while the other does not. If all items that could go on those layers are handled by that conversion, then there should be no problem, and I don't think it was a limitation from the DXF code. Some testing just now shows that all the drawing tools seem to work (line, circle, arc and graphic polygon). They output their outline polygons when requested, and their center lines when requested. However, items such as a dimension are not able to be converted to a polygonal contour, so they are not exported when polygons are requested just when center lines are requested.

Perhaps the text for the box could be changed to:
"Plot all layers in outline mode"
with the tooltip saying:
"Check to plot all layers as the outlines of items (line segments become rectangles showing the drawn edges and their thickness). Note, dimension markers cannot be not exported with this option.
Uncheck to plot all graphic items on the *.SilkS, *.User, Edge.Cuts, Margin, *.CrtYd, and *.Fab layers with a line thickness of 0 (line segments are represented by their center line)."
or something to that effect. (Possibly shorten the description for checked, since it seems kind of long).