Comment 9 for bug 1817896

Revision history for this message
Seth Hillbrand (sethh) wrote :

I'm fine with this approach. The only minor bits are:

1) Can you fix the capitalization formatting? I know MIN_GRID_SIZE is all-caps but it shouldn't be. It is a local variable so it should have the first character lower case and the rest either lower or camel case.

2) You have an extra line of spaces.

3) Grid size is an x/y pair of reals. You should cast the value you want explicitly to int and then use that for comparison. You want to use KiROUND() for this (note the capitalization of 'i')