Oversized +/- spinbuttons on GTK+ 3

[John Beard]

On the current master with GTK+ 3, I see very large spin buttons in the UI, for example in the grid display settings.

Attached is a screenshot.

-----

Application: kicad
Version: (6.0.0-rc1-dev-1239-gad9916a93), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.62.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.4) libssh2/1.8.0 nghttp2/1.34.0
Platform: Linux 4.18.16-arch1-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.62.0
    Compiler: GCC 8.2.1 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Nick Østergaard (nickoe)]

They have been oversized strangly like this for a long time, even on gtk2 as well.

[Wayne Stambaugh (stambaughw)]

It's an issue on windows as well. This is because we use separate wxSpinButton and wxControl objects instead of the integrated wxSpinCtrl objects which should resolve the over sized spin buttons. The problem is the event handling is different which will require quite a bit of code changes to make the wxSpinCtrl objects work the same as the current behavior.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 203019d959887bcf13fc99cc04e8160124c7df66
https://git.launchpad.net/kicad/patch/?id=203019d959887bcf13fc99cc04e8160124c7df66