Comment 12 for bug 1789048

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

@JP, I did some testing and it appears to be working as expected. I did notice that this does not work when pasting a sheet from the clipboard (none of the symbol references in the pasted sheet are cleared) but this is the current behavior which I believe was overlooked in the original paste code. I would think that we would want to have the same behavior as adding a new sheet with and existing schematic file. Pasted symbol references are cleared.

I have a few minor comments on the code:

Instead of silently returning from SCH_COMPONENT::AddSheetPathReferenceEntry() when aSheetPathName is empty or already exists, please add some asserts so any calls that violate these conditions get the developers attention.

Please remove your debugging output wrapped in #if 0/#endif from SCH_SCREENS::ClearAnnotationOfNewSheetPaths()

Other than that, everything looks good. Once this is finalized, it should be merged into the 5.0 branch. Thanks!