This patch looks correct to me. The wxPython console (kicad_pyshell)
should not be installed when KICAD_SCRIPTING_WXPYTHON=OFF. Anyone else
see any issues with this patch?
On 4/3/2018 5:51 AM, Mario wrote:
> You are right, CreatePythonShellWindow() won't be called when
> -DKICAD_SCRIPTING_WXPYTHON=OFF. But
> /usr/share/kicad/scripting/kicad_pyshell/__init__.py still somehow gets
> loaded at runtime which would import wxPython! I don't know Python well
> but maybe when KiCad intitializes Python scripting, it loads everything
> __init__.py from scripting directory.
>
> If that is so, then KiCad shouldn't install kicad_pyshell when
> -DKICAD_SCRIPTING_WXPYTHON=OFF in pcbnew/CMakeLists.txt (see the
> attached patch).
>
> ** Patch added: "kicad-wxpython.patch"
> https://bugs.launchpad.net/kicad/+bug/1760200/+attachment/5099601/+files/kicad-wxpython.patch
>
This patch looks correct to me. The wxPython console (kicad_pyshell) _WXPYTHON= OFF. Anyone else
should not be installed when KICAD_SCRIPTING
see any issues with this patch?
On 4/3/2018 5:51 AM, Mario wrote: llWindow( ) won't be called when SCRIPTING_ WXPYTHON= OFF. But kicad/scripting /kicad_ pyshell/ __init_ _.py still somehow gets SCRIPTING_ WXPYTHON= OFF in pcbnew/ CMakeLists. txt (see the wxpython. patch" /bugs.launchpad .net/kicad/ +bug/1760200/ +attachment/ 5099601/ +files/ kicad-wxpython. patch
> You are right, CreatePythonShe
> -DKICAD_
> /usr/share/
> loaded at runtime which would import wxPython! I don't know Python well
> but maybe when KiCad intitializes Python scripting, it loads everything
> __init__.py from scripting directory.
>
> If that is so, then KiCad shouldn't install kicad_pyshell when
> -DKICAD_
> attached patch).
>
> ** Patch added: "kicad-
> https:/
>