Comment 3 for bug 1746546

Hi Maciej,

For example, in '/3d-viewer/3d_cache/sg/scenegraph.cpp', I have several
compile errors with 'glm::rotate'.

Without GLM_ENABLE_EXPERIMENTAL, and to avoid error, the code should be
modified.
Line 745, from :
glm::dmat4 rM = glm::rotate( rotation_angle, glm::dvec3( rX, rY, rZ ) );

To :
glm::dmat4 rM = glm::rotate( rM, rotation_angle, glm::dvec3( rX, rY, rZ ) );

There are several other errors like this :
* glm::rotate in '3d-viewer/3d_rendering/3d_render_ogl_legacy/
c3d_render_createscene_ogl_legacy.cpp', line 113

* #include <glm/gtx/transform.hpp>, in
'plugins/3d/vrml/v1/vrml1_node.h', line 36

For this later case, here is the error displayed :

In file included from
/home/phil/src/kicad/plugins/3d/vrml/v1/vrml1_node.h:36:0,
                  from
/home/phil/src/kicad/plugins/3d/vrml/v1/vrml1_base.h:36,
                  from /home/phil/src/kicad/plugins/3d/vrml/vrml.cpp:41:
/usr/include/glm/gtx/transform.hpp:23:3: error: #error "GLM:
GLM_GTX_transform is an experimental extension and may change in the
future. Use #define GLM_ENABLE_EXPERIMENTAL before including it, if you
really want to use it."

For your information, I use the latest gcc 7.3 compiler on Linux.

Do not hesitate to ask for more feedback if needed.

Best regards,
J. Ph.

Le 31/01/2018 à 17:52, Maciej Suminski a écrit :
> Hi Jean Philippe,
>
> Thank you for the patch. Would you tell us more about the error? I
> wonder why now GLM requires GLM_ENABLE_EXPERIMENTAL definition, as
> presumably we have not started using any features introduced in 0.9.9.
>