Comment 13 for bug 1740022

If this is the case, then the logic is broken. In the original design
externally defined variables always took precedence over internally
defined variables. Setting an internal variable should not replace the
externally defined variable when edited using the path configuration
dialog nor should a variable defined in the settings.

On 3/8/2018 6:35 AM, Jeff Young wrote:
> The logic is broken.
>
> The first time you run KiCad, we apply the env-vars-override-kicad-
> settings rule.
>
> However, if you ever open the Configure Paths dialog and click OK, we'll
> write ALL the path definitions into the settings file -- but you only
> get a warning if you modified one of the externally set ones.
>
> After that we always overwrite the env-vars with the settings file, so
> there are no more externally-defined flags. And you therefore won't get
> a warning if you change one of them. (Nor will kicad pay any attention
> to changes made in the env vars.)
>
> You might say: only write out the changed paths, and this is fine.
> Except that everyone out there already has them all written into their
> settings files, and we probably don't want to just blast those. Beside,
> the warning says changes only take effect until the next run -- which
> means we shouldn't be saving those at all -- even if changed.
>
> Shall I reverse the logic so that we only pay attention to the settings
> file if the variable was NOT set externally?
>
> ** Changed in: kicad
> Status: Opinion => Triaged
>
> ** Changed in: kicad
> Importance: Undecided => Medium
>
> ** Changed in: kicad
> Assignee: (unassigned) => Jeff Young (jeyjey)
>
> ** Changed in: kicad
> Milestone: None => 5.0.0-rc2
>