Comment 21 for bug 1737361

Revision history for this message
Jeff Young (jeyjey) wrote : Re: [Bug 1737361] Re: Eeshema - Tools - Component Table View enters edited content on the wrong row

Thanks for checking, @Oivind.

The final version /should/ be the same for you as it only has different code for Linux. I know, famous last words….

> On 25 Apr 2018, at 01:56, Oivind Toien <email address hidden> wrote:
>
> @jeyjey, I am lagging a bit behind here, but I just found that the
> Windows nightly now had updated (5.0.0-rc2-dev-570-gbfc70c820), April
> 24, and tested. As shown in the attached image, the headings now look
> fine on my screen showing both the "Show" and "Group by" heading, so
> there is no incentive to try resize them (although it still pretends it
> can do so). Everything else also looks normal in this version. I am not
> sure when it updated (it seems the schedule for build has changed; it
> used to be shortly after midnight local time Alaska, but daylight
> savings time might have a play). This test would likely not reflect the
> last commit - I will test again once it updates again.
>
> ** Attachment added: "Choose-Symbols-002.jpg"
> https://bugs.launchpad.net/kicad/+bug/1737361/+attachment/5126796/+files/Choose-Symbols-002.jpg
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1737361
>
> Title:
> Eeshema - Tools - Component Table View enters edited content on the
> wrong row
>
> Status in KiCad:
> Fix Committed
>
> Bug description:
> 1. In an existing schematic go into Tools - Component Table View. The information appears to be correctly displayed and sorted.
> 2. Click on a field and click it again to enter new information or edit the content of the field.
> 3. After changing or typing new information, the apply changes button is still grayed out, so the only way to continue is to click another field. If a field on the same row is clicked the changed information is entered into the correct filed and now appears in bold Italics. ** However if a field on a different row is clicked instead the just edited information will be entered into that row **, which is clearly incorrect.
>
>
> Some related side notes:
> a) The pre-selection of the field to edit before the final click to edit it highlights the whole row, which makes it a bit uncertain which of the fields have been selected. For instance if one field of the same row is first edited and then the next filed is then clicked to select that, there is no apparent visible change to confirm the selection. When I first learned that I could edit these fields, I tried to double click these field due to that lack of the visual feedback, but the double-click was often too fast to be accepted as the required two separate clicks. If there had been visual feedback on the first click, I would have understood that the selection was not to happen with a double click. So my suggestion is to only highlight the selected field.
> b) The description fields do not appear to be editable; is that by design or a bug?
>
>
> Application: kicad
> Version: (2017-12-08 revision d205366da)-makepkg, release build
> Libraries:
> wxWidgets 3.0.3
> libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
> Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
> Build Info:
> wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
> Boost: 1.60.0
> Curl: 7.54.1
> Compiler: GCC 7.1.0 with C++ ABI 1011
>
> Build settings:
> USE_WX_GRAPHICS_CONTEXT=OFF
> USE_WX_OVERLAY=OFF
> KICAD_SCRIPTING=ON
> KICAD_SCRIPTING_MODULES=ON
> KICAD_SCRIPTING_WXPYTHON=ON
> KICAD_SCRIPTING_ACTION_MENU=ON
> BUILD_GITHUB_PLUGIN=ON
> KICAD_USE_OCE=ON
> KICAD_SPICE=ON
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1737361/+subscriptions