Comment 15 for bug 1636549

I reviewed this patch and while it does solve a problem, I do not care for the solution. It has too many issues is not a complete solution for plotting. Here is a short list of issues:

The plot on save setting it part of the dialog. This setting has nothing to do with the plot dialog and should be handled in the schematic editor code.

The plot type and setting will always be the last plot the user performed using the plot dialog. This may or may not be what the user expected and there is no way to set this without performing a plot using plot dialog.

The plotting is called before the schematic is saved and the cache library is saved. If something causes the plotting to crash, the schematic will not be saved and the cache library will not be saved. I consider this a grave design flaw. Saving the schematic should be a priority over plotting.

I am planning to create a plot manager feature for Pcbnew which would allow for complex plotting requirements including multiple plots, custom file name suffixes, prefixes, and extensions, custom destination folders, etc. This should lay a foundation for a similar feature in Eeschema. It will be a while before I get to this because the new schematic file formats are my next project after the stable 5 release. I am hesitant to apply this patch because it will be removed at some point in the future. If there is enough support for this, I would consider it if you move the check for plot on save out of the dialog code and into the schematic editor frame code and you moved the plotting after the schematic and cache library are saved.