Version string isn't set in macOS app bundle

[Per Olofsson]

CFBundleShortVersionString and CFBundleVersion are empty in KiCad.app/Contents/Info.plist, which complicates deployment with tools such as Munki. CFBundleShortVersionString should be set to the user visible version number (e.g. "4.0.3-rc7"), whereas CFBundleVersion should be a monotonically increasing period separated number - the latest commit revision seems like a good fit.

Application: kicad
Version: 4.0.3-rc7-stable release build
wxWidgets: Version 3.0.2 (debug,UTF-8,compiler with C++ ABI 1002,GCC 4.2.1,STL containers,compatible with 2.8)
Platform: Mac OS X (Darwin 15.5.0 x86_64), 64 bit, Little endian, wxMac
Boost version: 1.57.0
         USE_WX_GRAPHICS_CONTEXT=OFF
         USE_WX_OVERLAY=ON
         KICAD_SCRIPTING=ON
         KICAD_SCRIPTING_MODULES=ON
         KICAD_SCRIPTING_WXPYTHON=ON
         USE_FP_LIB_TABLE=HARD_CODED_ON
         BUILD_GITHUB_PLUGIN=ON

[xzcvczx (xzcvczx)]

I looked into doing this, It would be realtively simple for hte stables, just a case of adding it to the CMakeLists.txt files, However in the case of the nightlies the current version is never exposed to cmake only inside a header file that is used from the source code, So this would either have to be parsed out of the generated header (not a fan at all of this option) or preferably the method of which it figures out the latest revision would have to be changed so thats exposed to CMake.

Currently another version of cmake is run that checks for a .bzr or .git subdirectory in the src tree and then uses bzr and/or git to figure out the revision number and then creates the required header file.

This is also done from the common/CMakeLists.txt rather than the root one which also doesn't seem like the best idea if it were done properly and the version information was just acquired into a cmake variable and then passed to the make process as a -D or even creating the header file from the provided revision/version number all the time.