ppa daily build package shows Version: no-vcs-found-undefined

Bug #1635780 reported by Eldar Khayrullin
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
KiCad
Invalid
Undecided
Jean-Samuel Reynaud

Bug Description

See theme.

Application: kicad
Version: no-vcs-found-undefined, release build
Libraries: wxWidgets 3.0.2
           libcurl/7.50.1 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.33 librtmp/2.3
Platform: Linux 4.8.0-26-generic x86_64, 64 bit, Little endian, wxGTK
- Build Info -
wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8)
Boost: 1.61.0
Curl: 7.50.1
KiCad - Compiler: GCC 6.2.0 with C++ ABI 1010
        Settings: USE_WX_GRAPHICS_CONTEXT=OFF
                  USE_WX_OVERLAY=OFF
                  KICAD_SCRIPTING=ON
                  KICAD_SCRIPTING_MODULES=ON
                  KICAD_SCRIPTING_WXPYTHON=ON
                  BUILD_GITHUB_PLUGIN=ON
                  KICAD_USE_SCH_IO_MANAGER=OFF
                  KICAD_USE_OCE=ON

Tags: ppa
Revision history for this message
Franck78 (fbourdonnec) wrote :

ah ah, don't bother reporting bugs about version numbering, the head (wayne/charras) is proud to have invented the single product on earth with cumbersome behavior.

Here is what it does :

the makefile tries to guess a revision number from the git tree (and before that baazar). When it cannot find one, it puts "novcs_found".

you have something like $version="Kicad_novcs_found"

To solve this (already idiot) behavior, the team added a non clearly documented (not where you expect to find it, eg README.FIRST), a makefile option.

-DKICAD_BUILD_VERSION="what you want"

The list of wrong choices :

assume everyone have permanently access to a working free rapid reliable internet connection to compile kicad 'in development'

assume a regular user is interested in compiling kicad.

force a distribution package maker to choose a version number for the build.

assume a Kicad developer will report a bug instead of fixing it at first.....and this 'indication' is a great improvement. Just false. How many dev's reports vs normal user's report ?

assume a regular user want the most recent source instead of the last known good public released.

The rest of the world (not kicad) :

A downloaded source tarball is made available under a specific name. Postfix "Postfix 3.1 stable release".
When making the package, no cumbersome question is asked for selecting a version. By default the package knows 'who it is'. No exception.

The version string will be identical for all distribution (ubuntu, opensuse, debian,gentoo,...) or home made compilation :"POSTFIX-3.1".

If the package's maker needs to tweak the version string, most packages have at disposal a makefile option DEXTRA_VERSION="frktest"

resulting in a version string "POSTFIX-3.1-frktest"

There is absolutely no reason for Kicad not using this universal scheme.

If you (jp/w) want to add a rev suffix, you can do it automatically.

But having "kicad-novcs-found" or other funny name is just due to an idiot implementation, sorry.

Franck

Revision history for this message
Franck78 (fbourdonnec) wrote :

Can you believe it ?

https://git.launchpad.net/kicad/commit/?id=7e3c0258aa3a972a5667021a07dd0cc39a9aeb62

Another fix for the broken system used to guess a 'version' for the built package and it is still

ending with

+ set( KICAD_BUILD_VERSION "unknown" )
+ set( KICAD_FULL_VERSION "unknown" )

Incredible ! Two files to end up with that ! "unknown". An officially published tarball (like the many hundreds existing) and this unique app have no clue what version it is. I'm "unknown"

Really ???????????????????

And the worse ? Two variables now. When the only required one is KICAD_EXTRA_VERSION.

Revision history for this message
Jean-Samuel Reynaud (js-reynaud) wrote :

Not a PPA issue. It was fixed in kicad himself.

Changed in kicad:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.