Comment 4 for bug 1464373

Revision history for this message
Blair Bonnett (bcb) wrote : Re: [Bug 1464373] Re: Blind via hotkey calls up View menu

Wayne: Yes that's his patch. He's written it on a branch [1] of his fork of
my KiCad mirror, and submitted a pull request [2] to generate the diff from
master. I haven't, and nor will I, apply it to the mirror -- this is always
a straight copy of the bzr product branch.

Apparently I'm not getting notifications about pull requests since this
isn't the first. I'll see if I can add a note to the repository info saying
that while this a valid way of generating a diff, they need to post it
either to the related bug, or to the list to get it accepted.

[1] https://github.com/morio/kicad/tree/feature/fix-blind-via-hotkey
[2] https://github.com/blairbonnett-mirrors/kicad/pull/4

On 19 June 2015 at 07:41, Wayne Stambaugh <email address hidden>
wrote:

> @J. Morio Sakaguchi
>
> I'm assuming this is your patch since I see your email address. I want
> to make sure the correct person gets credit for authoring the patch.
> Also, why are you submitting patches to Blair Bonnett's personal branch
> and not the KiCad project so that bugs like this can be fixed for everyone?
>
> On 6/18/2015 1:50 AM, J. Morio Sakaguchi wrote:
> > Here is a possible fix. Add shift to the hotkey
> >
> https://patch-diff.githubusercontent.com/raw/blairbonnett-mirrors/kicad/pull/4.patch
> >
>
> --
> You received this bug notification because you are subscribed to KiCad.
> Matching subscriptions: kicad-bugs
> https://bugs.launchpad.net/bugs/1464373
>
> Title:
> Blind via hotkey calls up View menu
>
> Status in KiCad EDA Software Suite:
> New
>
> Bug description:
> In GAL, the default hotkey for blind vias (Alt-V) simultaneously
> places a blind via and opens the View menu. In legacy, it *only* calls
> up the View menu, I can only place the via using the context menu.
> Ideally, either the View hotkey would be ignored when the track tool
> is active, or the default hotkey would be moved to something that does
> not cause this conflict.
>
> Application: pcbnew
> Version: (after 2015-may-25 BZR unknown)-product debug build
> wxWidgets: Version 3.0.2 (debug,wchar_t,compiler with C++ ABI 1002,GCC
> 4.2.1,wx containers,compatible with 2.8)
> Platform: Linux 4.0.4-2-ARCH x86_64, 64 bit, Little endian, wxGTK
> Boost version: 1.58.0
> USE_WX_GRAPHICS_CONTEXT=OFF
> USE_WX_OVERLAY=OFF
> KICAD_SCRIPTING=OFF
> KICAD_SCRIPTING_MODULES=OFF
> KICAD_SCRIPTING_WXPYTHON=OFF
> USE_FP_LIB_TABLE=HARD_CODED_ON
> BUILD_GITHUB_PLUGIN=ON
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1464373/+subscriptions
>