@Dan, what happens when the legacy canvas is active? In other words, is the tool manager object pointer always valid? If not, your patch will segfault. Please check this and let me know so I can get this patch merged.
On 1/6/2018 9:51 PM, Dan Weatherill wrote: > This patch fixes this bug (by emitting a model change event when the design rules dialog is exited). > However, I may have done something "not allowed" in terms of directly dispatching an event. > > > ** Patch added: "0001-Send-model-change-event-on-design-rules-change.patch" > https://bugs.launchpad.net/kicad/+bug/1462929/+attachment/5032159/+files/0001-Send-model-change-event-on-design-rules-change.patch >
@Dan, what happens when the legacy canvas is active? In other words, is
the tool manager object pointer always valid? If not, your patch will
segfault. Please check this and let me know so I can get this patch merged.
On 1/6/2018 9:51 PM, Dan Weatherill wrote: model-change- event-on- design- rules-change. patch" /bugs.launchpad .net/kicad/ +bug/1462929/ +attachment/ 5032159/ +files/ 0001-Send- model-change- event-on- design- rules-change. patch
> This patch fixes this bug (by emitting a model change event when the design rules dialog is exited).
> However, I may have done something "not allowed" in terms of directly dispatching an event.
>
>
> ** Patch added: "0001-Send-
> https:/
>