Comment 8 for bug 1420916

Revision history for this message
Wayne Stambaugh (stambaughw) wrote : Re: [Bug 1420916] Re: placing a text: finishing dialog with keyboard not possible any more

Event handlers should not be defined in dialog derived objects. They
should be implemented in the base class using wxFormbuilder and then
overridden in the derived class. I also noticed that you have placed
Doxygen comments in the source (.cpp) file. This is a coding policy
violation. Doxygen comments belong in the header file. I understand
that the previous developer did this and you just repeated the error but
it is incorrect.

On 12/28/2017 02:35 PM, Jeff Young wrote:
> Patch attached. Also fixes the same issue in pcbnew text editing.
>
> ** Patch added: "0004-Enable-tab-navigation-and-shift-return-for-OK-in-mul.patch"
> https://bugs.launchpad.net/kicad/+bug/1420916/+attachment/5028521/+files/0004-Enable-tab-navigation-and-shift-return-for-OK-in-mul.patch
>
> ** Changed in: kicad
> Assignee: Jeff Young (jeyjey) => (unassigned)
>