Comment 15 for bug 1412528

On 1/21/2015 2:31 PM, Fat-Zer wrote:
>> Fat-Zer are you sure that all your patches apply cleanly against head now?
> yep one patch is already applied, the second is partially applied and a yet another one is lost its value...
>
> Here is a new patchset based on current HEAD.
>
>
> ** Attachment added: "kicad-patches.tar.bz2"
> https://bugs.launchpad.net/kicad/+bug/1412528/+attachment/4303307/+files/kicad-patches.tar.bz2
>

Here is my response to your proposed patches:

0001-EDA_BASE_FRAME-fix-a-Woverloaded-virtual-warning.patch

This is no longer necessary since remove the redundant IsActive()
definition from EDA_BASE_FRAME.

0002-LIB_PART-fix-a-Woverloaded-virtual-warning.patch

I don't like adding functions that should never get called (you should
always specify a aUnit) and possibly confuse developers just to get rid
of a compiler warning.

0003-DIALOG_LIB_NEW_COMPONENT-fix-yet-anoter-Woverloaded-.patch

I will commit this patch.

0004-A-minor-enhancement-in-EDA_ITEM.patch

This is one of those patches that I really don't see as necessary. Yes,
technically EDA_ITEM::Matches() only gets call by objects derived from
EDA_ITEM but doing so buys us nothing in terms of code reliability or
readability. I may apply this but it would be low on my priority list.

0005-fix-several-Woverloaded-virtual-warnings-in-common-d.patch

I didn't write this code so I'm not sure that removing these functions
makes sense. The original author may have intended to use them in the
future. If the person who wrote it steps up and says that it will never
be used, I will apply this patch.