Polygons and dashed lines

[Chris Gibson]

BZR4011

Win 7 and Vista

Eeschema.

When you draw a polygon, the icon seems to imply it's going to be a dashed line. However it draws a solid line on the screen. But then you plot it, you get a dashed line?

Surely they should be the same?

[Chris Gibson (chris-w-gibson)]

I've gone through this on eeschema and almost all the code is there. In fact it *is* all there. It's just that some parameters are not passed down the chain through the functions and then the last function overwrites the pen style anyway.

[Eldar Khayrullin (eldar)]

Same bug onnext config:
OS: Ubuntu 14.10
Application: kicad
Version: (2015-01-08 BZR 5359)-product Release build
wxWidgets: Version 3.0.1 (debug,wchar_t,compiler with C++ ABI 1002,GCC 4.9.1,wx containers,compatible with 2.8)
Platform: Linux 3.16.0-28-generic x86_64, 64 bit, Little endian, wxGTK
Boost version: 1.54.0
         USE_WX_GRAPHICS_CONTEXT=OFF
         USE_WX_OVERLAY=OFF
         KICAD_SCRIPTING=OFF
         KICAD_SCRIPTING_MODULES=OFF
         KICAD_SCRIPTING_WXPYTHON=OFF
         USE_FP_LIB_TABLE=HARD_CODED_ON
         BUILD_GITHUB_PLUGIN=ON

[Nick Østergaard (nickoe)]

Where in the code is this? Maybe you can propose a patch?

[Chris Gibson (chris-w-gibson)]

Sorry I can't remember. It's over 18 months ago. I suspect that code is all different now anyway.

[Eldar Khayrullin (eldar)]

Added patch that fixes it

[Nick Østergaard (nickoe)]

Ok, thanks. I see that you made it show the dashed line in eeschema. But what I really think is needed to fix this is that the user should be able to choose line type somehow.

The default should probably be the non dashed, as it has been previously on eeschema (not the plot).

Does the sch fileformat support different line styles?

Also, the patch has an issue, because the crosshair in libedit is also dashed lines now. This is not desireable, so this patch should probably not be comitted as is. I am not sure how to implement the above proposed changes.

[Eldar Khayrullin (eldar)]

If you want to use different line types, maybe use Bus Line instead solid lines and Notes Line how dashed line. This possible because Bus Line only used how visual line.

[jean-pierre charras (jp-charras)]

"This possible because Bus Line only used how visual line"
No.

[Nick Østergaard (nickoe)]

What do you mean by that Jean-Pierre? (or even Eldar)

[Nick Østergaard (nickoe)]

This bug could have a connection to https://bugs.launchpad.net/kicad/+bug/1405026

[jean-pierre charras (jp-charras)]

Bus lines can connect Bus labels.
This is never a good practice to use wires or bus lines as graphic items (although is is always possible).
(like it is not good to use labels as comments, although is is possible)
Graphic items are ignored by the ERC engine or the netlist generator, but other items are taken in account.

[Eldar Khayrullin (eldar)]

I was suggested to use as a temporary solution, because now ambiguous icon and the plot shows one thing, but when drawing see another. Correctly will see what will plot.

[Nick Østergaard (nickoe)]

Well IMHO it is a bug that the plot does not render as in eeschema. That the icon is dashed and the line is not, is just not user friendly. The fact that dashed lines can be drawn, I would love to be able to draw both linetypes.