many things that were deprecated long ago were never removed

Bug #1736985 reported by Matthew Edmonds
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
keystonemiddleware
In Progress
Low
Colleen Murphy

Bug Description

I just saw several deprecation warnings in keystonemiddleware complaining about things that should have been removed several releases ago. E.g.

1) https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/_auth.py#L33

2) https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/_auth.py#L43

3) https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/_auth.py#L72

And that's probably just scratching the surface. We should do a full sweep of keystonemiddleware and clean things up.

Changed in keystonemiddleware:
importance: Undecided → Medium
status: New → Triaged
tags: added: low-hanging-fruit office-hours
Revision history for this message
Matthew Edmonds (edmondsw) wrote :

will have to fix devstack's https://bugs.launchpad.net/devstack/+bug/1736988 first so as not to break the gate.

Changed in keystonemiddleware:
importance: Medium → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystonemiddleware (master)

Fix proposed to branch: master
Review: https://review.openstack.org/613651

Changed in keystonemiddleware:
assignee: nobody → Morgan Fainberg (mdrnstm)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/613675

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystonemiddleware (master)

Reviewed: https://review.openstack.org/613651
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=7e1b53625990bb08425645cb92f36e16bd67db7f
Submitter: Zuul
Branch: master

commit 7e1b53625990bb08425645cb92f36e16bd67db7f
Author: Morgan Fainberg <email address hidden>
Date: Fri Oct 26 10:32:28 2018 -0700

    Stop supporting revocation list

    With keystone's move to eliminating pki, pkiz, and uuid tokens the
    revocation list is no longer generated. Keystonemiddleware no longer
    needs to attempt to retrieve it and reference it.

    Change-Id: Ief3bf1941e62f9136dbed11877bca81c4102041b
    closes-bug: #1361743
    partial-bug: #1649735
    partial-bug: #1736985

Changed in keystonemiddleware:
assignee: Morgan Fainberg (mdrnstm) → Gage Hugo (gagehugo)
Gage Hugo (gagehugo)
Changed in keystonemiddleware:
assignee: Gage Hugo (gagehugo) → Morgan Fainberg (mdrnstm)
Changed in keystonemiddleware:
assignee: Morgan Fainberg (mdrnstm) → Gage Hugo (gagehugo)
Gage Hugo (gagehugo)
Changed in keystonemiddleware:
assignee: Gage Hugo (gagehugo) → Morgan Fainberg (mdrnstm)
Changed in keystonemiddleware:
assignee: Morgan Fainberg (mdrnstm) → Gage Hugo (gagehugo)
Gage Hugo (gagehugo)
Changed in keystonemiddleware:
assignee: Gage Hugo (gagehugo) → Morgan Fainberg (mdrnstm)
Changed in keystonemiddleware:
assignee: Morgan Fainberg (mdrnstm) → Colleen Murphy (krinkle)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/613675
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=b3e84aafc0302b1a87754f438696794076ba844f
Submitter: Zuul
Branch: master

commit b3e84aafc0302b1a87754f438696794076ba844f
Author: Morgan Fainberg <email address hidden>
Date: Fri Oct 26 12:33:28 2018 -0700

    Remove PKI/PKIZ support

    Keystone server no longer supports PKI/PKIZ. This change removes
    keystonemiddleware's support of PKI/PKIZ and associated code.

    Change-Id: I9a6639a2aa3774be61972d57f38220f66fd5c0e8
    closes-bug: #1649735
    partial-bug: #1736985

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.