using long-deprecated keystonemiddleware options

[Matthew Edmonds]

2017-11-21 15:00:12.259228 | ubuntu-xenial | AuthToken middleware is set with keystone_authtoken.service_token_roles_required set to False. This is backwards compatible but deprecated behaviour. Please set this to True.
2017-11-21 15:00:12.259452 | ubuntu-xenial | Use of the auth_admin_prefix, auth_host, auth_port, auth_protocol, identity_uri, admin_token, admin_user, admin_password, and admin_tenant_name configuration options was deprecated in the Mitaka release in favor of an auth_plugin and its related options. This class may be removed in a future release.
2017-11-21 15:00:12.260182 | ubuntu-xenial | Configuring admin URI using auth fragments was deprecated in the Kilo release, and will be removed in the Newton release, use 'identity_uri\ instead.

from http://logs.openstack.org/91/515291/3/check/openstack-tox-py27/0354f70/job-output.txt.gz#_2017-11-21_15_00_12_259228

shows that we're still using deprecated keystonemiddleware options, some of them long-deprecated and in need of removal. But before they can be removed (tracked with https://bugs.launchpad.net/keystonemiddleware/+bug/1736985 ) we need to stop using them.

[Andrea Frittoli (andrea-frittoli)]

It's not clear to me why this was filed as devstack? The link provided points to keystonemiddleware unit tests, so those options need to be removed from there.

[Matthew Edmonds (edmondsw)]

@Andrea It's because DevStack is using deprecated keystonemiddleware options. DevStack needs to stop using those options before keystonemiddleware can remove them (which has a separate defect, as linked in the description).

It's not immediately clear where DevStack is using these deprecated options, but here are a few places that searching found:

https://github.com/openstack-dev/devstack/blob/924b1149c8138bf1401aaef709e00f680509c33f/lib/cinder#L219-L226 (except line 222, which is not deprecated)

[Lance Bragstad (lbragstad)]

The link to lib/cinder in devstack is using inicomment, which appears to just comment out lines in ini files. If that is the case, couldn't we just remove those line?

[Matthew Edmonds (edmondsw)]

oh, then I probably just scanned too quickly and missed that. So it must be something else using the old property/-ies that we still need to track down.

[Lance Bragstad (lbragstad)]

Either way - it's possible to clean those up, too.

[Matthew Edmonds (edmondsw)]

I'm not seeing those deprecation warnings in more recent results: http://logs.openstack.org/95/551495/4/check/openstack-tox-py27/80fa734/job-output.txt.gz