using long-deprecated keystonemiddleware options

Bug #1736988 reported by Matthew Edmonds
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
devstack
Invalid
Low
Unassigned
keystonemiddleware
Invalid
Undecided
Unassigned

Bug Description

2017-11-21 15:00:12.259228 | ubuntu-xenial | AuthToken middleware is set with keystone_authtoken.service_token_roles_required set to False. This is backwards compatible but deprecated behaviour. Please set this to True.
2017-11-21 15:00:12.259452 | ubuntu-xenial | Use of the auth_admin_prefix, auth_host, auth_port, auth_protocol, identity_uri, admin_token, admin_user, admin_password, and admin_tenant_name configuration options was deprecated in the Mitaka release in favor of an auth_plugin and its related options. This class may be removed in a future release.
2017-11-21 15:00:12.260182 | ubuntu-xenial | Configuring admin URI using auth fragments was deprecated in the Kilo release, and will be removed in the Newton release, use 'identity_uri\ instead.

from http://logs.openstack.org/91/515291/3/check/openstack-tox-py27/0354f70/job-output.txt.gz#_2017-11-21_15_00_12_259228

shows that we're still using deprecated keystonemiddleware options, some of them long-deprecated and in need of removal. But before they can be removed (tracked with https://bugs.launchpad.net/keystonemiddleware/+bug/1736985 ) we need to stop using them.

Tags: office-hours
Changed in devstack:
status: New → Confirmed
Revision history for this message
Andrea Frittoli (andrea-frittoli) wrote :

It's not clear to me why this was filed as devstack? The link provided points to keystonemiddleware unit tests, so those options need to be removed from there.

Changed in devstack:
status: Confirmed → Incomplete
Revision history for this message
Matthew Edmonds (edmondsw) wrote :

@Andrea It's because DevStack is using deprecated keystonemiddleware options. DevStack needs to stop using those options before keystonemiddleware can remove them (which has a separate defect, as linked in the description).

It's not immediately clear where DevStack is using these deprecated options, but here are a few places that searching found:

https://github.com/openstack-dev/devstack/blob/924b1149c8138bf1401aaef709e00f680509c33f/lib/cinder#L219-L226 (except line 222, which is not deprecated)

Changed in devstack:
status: Incomplete → New
Changed in keystonemiddleware:
status: New → Invalid
Revision history for this message
Lance Bragstad (lbragstad) wrote :

The link to lib/cinder in devstack is using inicomment, which appears to just comment out lines in ini files. If that is the case, couldn't we just remove those line?

Revision history for this message
Matthew Edmonds (edmondsw) wrote :

oh, then I probably just scanned too quickly and missed that. So it must be something else using the old property/-ies that we still need to track down.

Revision history for this message
Lance Bragstad (lbragstad) wrote :

Either way - it's possible to clean those up, too.

tags: added: office-hours
Changed in devstack:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Matthew Edmonds (edmondsw) wrote :

I'm not seeing those deprecation warnings in more recent results: http://logs.openstack.org/95/551495/4/check/openstack-tox-py27/80fa734/job-output.txt.gz

Changed in devstack:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.