Comment 2 for bug 1838704

Reviewed: https://review.opendev.org/674139
Committed: https://git.openstack.org/cgit/openstack/keystoneauth/commit/?id=b2b5ad3cb1ff05e08c22973bb079125214ba7bcf
Submitter: Zuul
Branch: master

commit b2b5ad3cb1ff05e08c22973bb079125214ba7bcf
Author: Alex Schultz <email address hidden>
Date: Thu Aug 1 16:08:24 2019 -0600

    Cleanup session on delete

    If an external session object was not passed to the Session class, we
    create a requests.Session() on our own. Once this is used, it may still
    have an open connection when the auth Session is closed. We need to
    handle the closing of the requests.Session() ourselves if we created
    one. If you do not close it, a ResourceWarning may be reported about the
    socket that is left open. If a session object is provided, we do not
    attempt to close it as it will be up to the code consuming keystoneauth
    to properly handle cleaning up the provided session.

    Change-Id: I590755d665b371c76ba8e02836d81d41a95ac601
    Closes-Bug: #1838704