Comment 6 for bug 1616105

Revision history for this message
Jamie Lennox (jamielennox) wrote : Re: Request of large files raises a MemoryError due to logging

So keystoneclient is deprecated but this may be the sort of thing we want to fix anyway.

In keystoneauth we fixed this with [1] which basically ensures any text we print is ascii - I'm not sure if ascii is correct here because we would want to show unicode but that may raise some false positives.

Whilst this doesn't explicitly check size it will make sure we don't print any images which is the original bug.

I would like to do something more proactive than simply catch MemoryError because by the time you're at MemoryError you're kinda screwed.

Can we port terry's patch over to ksc? does that solve the issue?

[1] https://review.openstack.org/#/c/214380/