Comment 3 for bug 982945

Revision history for this message
Ionuț Arțăriși (mapleoin) wrote :

Thanks Rafael. That's a very good reference. I now understand why it was done like this, but I don't think that issue was solved. The fix on that bug is more like a hasty hack to just get over it.

Ideally we would still be able to run the functional tests against keystoneclient, but it would be against our installed version of keystoneclient, not the one in git. This is easily accomplished currently by just not running the git clone command which makes the tests import the system-installed keystoneclient.

The problem is that we would have to disable/delete one of these two test classes: KcMasterTestCase or KcEssex3TestCase in test_keystoneclient.py. Otherwise one of them would always fail because the corresponding keystoneclient version is not installed on the system.

Even from the name of those test classes it's clear that something is wrong. Those are basically versioned classes (KcMasterTestCase, KcEssex3TestCase). That versioning information is already present in keystoneclient's git.

So I guess this question remains: why aren't the individual keystoneclient versions tested against keystone rather than testing keystone against all the existing keystoneclient versions?