Comment 24 for bug 1873290

Revision history for this message
Mohammed Naser (mnaser) wrote : Re: OAuth1 request token authorize silently ignores roles parameter

Hi everyone,

I think the patch is not applying cleanly:

============
➜ keystone git:(master) (☸ N/A) pwd
/Users/mnaser/src/opendev.org/openstack/keystone
➜ keystone git:(master) (☸ N/A) git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
➜ keystone git:(master) (☸ N/A) patch -p1 < ~/Downloads/0003-Ensure-OAuth1-authorized-roles-are-respected.patch-master
patching file keystone/api/_shared/EC2_S3_Resource.py
Hunk #1 FAILED at 84.
Hunk #2 FAILED at 104.
Hunk #3 FAILED at 122.
Hunk #4 FAILED at 148.
4 out of 4 hunks FAILED -- saving rejects to file keystone/api/_shared/EC2_S3_Resource.py.rej
patching file keystone/api/credentials.py
Hunk #1 FAILED at 74.
Hunk #2 succeeded at 85 with fuzz 2 (offset -7 lines).
Hunk #3 FAILED at 152.
Hunk #4 FAILED at 168.
3 out of 4 hunks FAILED -- saving rejects to file keystone/api/credentials.py.rej
patching file keystone/models/token_model.py
patching file keystone/tests/unit/test_v3_credential.py
Hunk #2 succeeded at 260 with fuzz 2 (offset -83 lines).
Hunk #3 succeeded at 502 (offset -172 lines).
patching file keystone/tests/unit/test_v3_oauth1.py
patching file releasenotes/notes/bug-1873290-ff7f8e4cee15b75a.yaml
➜ keystone git:(master) ✗ (☸ N/A)
============

Some parts (like in credentials.py reference code that doesn't seem to exist anywhere visible to me).