| 2019-09-17 01:26:13 |
zhufl |
bug |
|
|
added bug |
| 2019-09-17 01:27:06 |
zhufl |
description |
def _perform_auth(cls, protocol_id):
idps = PROVIDERS.federation_api.list_idps()
for idp in idps:
try:
remote_id_name = federation_utils.get_remote_id_parameter(
idp, protocol_id)
except exception.FederatedProtocolNotFound:
# no protocol for this IdP, so this can't be the IdP we're
# looking for
continue # zhufl: if no remote_id_name is found, we'll get
# "NameError: name 'remote_id' is not defined" exception
# in the next line when we first use remote_id before definition.
remote_id = flask.request.environ.get(remote_id_name)
if remote_id:
break
if not remote_id:
msg = 'Missing entity ID from environment'
tr_msg = _('Missing entity ID from environment')
LOG.error(msg)
raise exception.Unauthorized(tr_msg) |
def _perform_auth(cls, protocol_id):
idps = PROVIDERS.federation_api.list_idps()
for idp in idps:
try:
remote_id_name = federation_utils.get_remote_id_parameter(
idp, protocol_id)
except exception.FederatedProtocolNotFound:
# no protocol for this IdP, so this can't be the IdP we're
# looking for
continue # zhufl: if no remote_id_name is found, we'll
# get "NameError: name 'remote_id' is not
# defined" exception in the next line when we
# first use remote_id before definition.
remote_id = flask.request.environ.get(remote_id_name)
if remote_id:
break
if not remote_id:
msg = 'Missing entity ID from environment'
tr_msg = _('Missing entity ID from environment')
LOG.error(msg)
raise exception.Unauthorized(tr_msg) |
|
| 2019-09-17 01:28:10 |
zhufl |
description |
def _perform_auth(cls, protocol_id):
idps = PROVIDERS.federation_api.list_idps()
for idp in idps:
try:
remote_id_name = federation_utils.get_remote_id_parameter(
idp, protocol_id)
except exception.FederatedProtocolNotFound:
# no protocol for this IdP, so this can't be the IdP we're
# looking for
continue # zhufl: if no remote_id_name is found, we'll
# get "NameError: name 'remote_id' is not
# defined" exception in the next line when we
# first use remote_id before definition.
remote_id = flask.request.environ.get(remote_id_name)
if remote_id:
break
if not remote_id:
msg = 'Missing entity ID from environment'
tr_msg = _('Missing entity ID from environment')
LOG.error(msg)
raise exception.Unauthorized(tr_msg) |
def _perform_auth(cls, protocol_id):
idps = PROVIDERS.federation_api.list_idps()
for idp in idps:
try:
remote_id_name = federation_utils.get_remote_id_parameter(
idp, protocol_id)
except exception.FederatedProtocolNotFound:
# no protocol for this IdP, so this can't be the IdP we're
# looking for
continue # zhufl: if no remote_id_name is found,
# we'll get "NameError: name 'remote_id'
# is not defined" exception in the next line
# when we first use remote_id before
# definition.
remote_id = flask.request.environ.get(remote_id_name)
if remote_id:
break
if not remote_id:
msg = 'Missing entity ID from environment'
tr_msg = _('Missing entity ID from environment')
LOG.error(msg)
raise exception.Unauthorized(tr_msg) |
|
| 2019-09-17 01:30:29 |
zhufl |
description |
def _perform_auth(cls, protocol_id):
idps = PROVIDERS.federation_api.list_idps()
for idp in idps:
try:
remote_id_name = federation_utils.get_remote_id_parameter(
idp, protocol_id)
except exception.FederatedProtocolNotFound:
# no protocol for this IdP, so this can't be the IdP we're
# looking for
continue # zhufl: if no remote_id_name is found,
# we'll get "NameError: name 'remote_id'
# is not defined" exception in the next line
# when we first use remote_id before
# definition.
remote_id = flask.request.environ.get(remote_id_name)
if remote_id:
break
if not remote_id:
msg = 'Missing entity ID from environment'
tr_msg = _('Missing entity ID from environment')
LOG.error(msg)
raise exception.Unauthorized(tr_msg) |
def _perform_auth(cls, protocol_id):
idps = PROVIDERS.federation_api.list_idps()
for idp in idps:
try:
remote_id_name = federation_utils.get_remote_id_parameter(
idp, protocol_id)
except exception.FederatedProtocolNotFound:
# no protocol for this IdP, so this can't be the IdP we're
# looking for
continue # zhufl: if no remote_id_name is found,
# we'll get "NameError: name 'remote_id'
# is first use remote_id before definition.
remote_id = flask.request.environ.get(remote_id_name)
if remote_id:
break
if not remote_id:
msg = 'Missing entity ID from environment'
tr_msg = _('Missing entity ID from environment')
LOG.error(msg)
raise exception.Unauthorized(tr_msg) |
|
| 2019-09-17 01:31:42 |
zhufl |
description |
def _perform_auth(cls, protocol_id):
idps = PROVIDERS.federation_api.list_idps()
for idp in idps:
try:
remote_id_name = federation_utils.get_remote_id_parameter(
idp, protocol_id)
except exception.FederatedProtocolNotFound:
# no protocol for this IdP, so this can't be the IdP we're
# looking for
continue # zhufl: if no remote_id_name is found,
# we'll get "NameError: name 'remote_id'
# is first use remote_id before definition.
remote_id = flask.request.environ.get(remote_id_name)
if remote_id:
break
if not remote_id:
msg = 'Missing entity ID from environment'
tr_msg = _('Missing entity ID from environment')
LOG.error(msg)
raise exception.Unauthorized(tr_msg) |
def _perform_auth(cls, protocol_id):
�idps = PROVIDERS.federation_api.list_idps()
�for idp in idps:
�try:
�remote_id_name = federation_utils.get_remote_id_parameter(
�idp, protocol_id)
�except exception.FederatedProtocolNotFound:
�# no protocol for this IdP, so this can't be the IdP we're
�# looking for
�continue # zhufl: if no remote_id_name is found,
# we'll get "NameError: name 'remote_id'
# is first use remote_id before definition.
�remote_id = flask.request.environ.get(remote_id_name)
�if remote_id:
�break
�if not remote_id:
�msg = 'Missing entity ID from environment'
�tr_msg = _('Missing entity ID from environment')
�LOG.error(msg)
�raise exception.Unauthorized(tr_msg) |
|
| 2019-09-17 01:34:45 |
zhufl |
description |
def _perform_auth(cls, protocol_id):
�idps = PROVIDERS.federation_api.list_idps()
�for idp in idps:
�try:
�remote_id_name = federation_utils.get_remote_id_parameter(
�idp, protocol_id)
�except exception.FederatedProtocolNotFound:
�# no protocol for this IdP, so this can't be the IdP we're
�# looking for
�continue # zhufl: if no remote_id_name is found,
# we'll get "NameError: name 'remote_id'
# is first use remote_id before definition.
�remote_id = flask.request.environ.get(remote_id_name)
�if remote_id:
�break
�if not remote_id:
�msg = 'Missing entity ID from environment'
�tr_msg = _('Missing entity ID from environment')
�LOG.error(msg)
�raise exception.Unauthorized(tr_msg) |
1. Problem
In function _perform_auth, if no remote_id_name is found,
we'll get "NameError: name 'remote_id' is not defined" exception
when we first use remote_id before definition.
def _perform_auth(cls, protocol_id):
idps = PROVIDERS.federation_api.list_idps()
for idp in idps:
try:
remote_id_name = federation_utils.get_remote_id_parameter(
idp, protocol_id)
except exception.FederatedProtocolNotFound:
# no protocol for this IdP, so this can't be the IdP we're
# looking for
continue
remote_id = flask.request.environ.get(remote_id_name)
if remote_id:
break
if not remote_id:
msg = 'Missing entity ID from environment'
tr_msg = _('Missing entity ID from environment')
LOG.error(msg)
raise exception.Unauthorized(tr_msg)
2. Fix
Add remote_id definition. |
|
| 2019-09-17 01:39:36 |
OpenStack Infra |
keystone: status |
New |
In Progress |
|
| 2019-09-17 01:39:36 |
OpenStack Infra |
keystone: assignee |
|
zhufl (zhu-fanglei) |
|
| 2019-09-17 06:20:19 |
OpenStack Infra |
keystone: assignee |
zhufl (zhu-fanglei) |
Colleen Murphy (krinkle) |
|
| 2019-09-17 17:13:17 |
Colleen Murphy |
keystone: importance |
Undecided |
Low |
|
| 2019-09-17 17:13:21 |
Colleen Murphy |
keystone: milestone |
|
train-rc1 |
|
| 2019-09-20 18:25:44 |
OpenStack Infra |
keystone: status |
In Progress |
Fix Released |
|
