_perform_auth may cause NameError exception
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| OpenStack Identity (keystone) |
Low
|
Colleen Murphy |
Bug Description
1. Problem
In function _perform_auth, if no remote_id_name is found,
we'll get "NameError: name 'remote_id' is not defined" exception
when we first use remote_id before definition.
def _perform_auth(cls, protocol_id):
idps = PROVIDERS.
for idp in idps:
try:
except exception.
# no protocol for this IdP, so this can't be the IdP we're
# looking for
remote_id = flask.request.
if remote_id:
break
if not remote_id:
msg = 'Missing entity ID from environment'
tr_msg = _('Missing entity ID from environment')
raise exception.
2. Fix
Add remote_id definition.
description: | updated |
description: | updated |
description: | updated |
description: | updated |
description: | updated |
Changed in keystone: | |
assignee: | nobody → zhufl (zhu-fanglei) |
status: | New → In Progress |
Changed in keystone: | |
assignee: | zhufl (zhu-fanglei) → Colleen Murphy (krinkle) |
Changed in keystone: | |
importance: | Undecided → Low |
milestone: | none → train-rc1 |
Colleen Murphy (krinkle) wrote : | #1 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit e224082ecd34720
Author: zhufl <email address hidden>
Date: Tue Sep 3 14:53:15 2019 +0800
Add remote_id definition in _perform_auth
This is to add remote_id definition in _perform_auth, otherwise
if no remote_id is found, we'll get "NameError: name 'remote_id'
is not defined" exception.
Change-Id: I2ad7dd6d9e7f74
Closes-Bug: #1844207
Changed in keystone: | |
status: | In Progress → Fix Released |
This issue was fixed in the openstack/keystone 16.0.0.0rc1 release candidate.
https:/ /review. opendev. org/679706