Comment 2 for bug 1797876

Revision history for this message
Lance Bragstad (lbragstad) wrote :

I think we need to make sure we check other parts of OpenStack before enforcing limits to be positive. Literally, negative limits don't make sense, but negative values are used in other services to denote "unbound" limits [0].

To support services migrating in-service limits to keystone, we might have to consider supporting negative numbers. Although, I don't see a case where a value less than -1 is required (min -1).

I also think we will have to consider the enforcement model, too. For example, with strict-two-level hierarchical limits, a parent with a limit of 10 cores should prevent a child from having a limit of -1 on cores. In that same example, if a parent as a limit of -1 cores then a child may have a limit of -1 cores, where parent.limit >= child.limit.

Thoughts?

[0] http://git.openstack.org/cgit/openstack/nova/tree/nova/conf/quota.py#n29