test_admin in VersionSingleAppTestCase expects public endpoint in a response

Bug #1478629 reported by Alexey Miroshkin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Alexey Miroshkin

Bug Description

In VersionSingleAppTestCase both test_public and test_admin methods use a helper method _test_version which expects public_port config value in a response. It has no impact on test result because of bug #1478000, admin and public endpoints are indistinguishable in test_versions.

Changed in keystone:
assignee: nobody → Alexey Miroshkin (amirosh)
summary: - test_admin in VersionSingleAppTestCase expects public endpoint
+ test_admin in VersionSingleAppTestCase expects public endpoint in a
+ response
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/206496

Changed in keystone:
status: New → In Progress
Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Low
Revision history for this message
Dolph Mathews (dolph) wrote :

I don't see how this bug is different from bug 1478629.

Revision history for this message
Alexey Miroshkin (amirosh) wrote :

@dolph well, those bugs are equals because it's the same bug, I assume you refer to bug 1478504, they are similar but defined in different classes in the same file

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/206496
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=5b6968d0af1a35bb76de0a78f3de43076f321195
Submitter: Jenkins
Branch: master

commit 5b6968d0af1a35bb76de0a78f3de43076f321195
Author: Alexey Miroshkin <email address hidden>
Date: Tue Jul 28 03:59:49 2015 -0700

    Fix test_admin to expect admin endpoint

    This fix makes test_admin expect admin endpoint in a response preserving
    the correct behaviour for test_public

    Change-Id: I2769eddb94918e16d3589d6237841c961eab435a
    Closes-Bug: #1478629

Changed in keystone:
status: In Progress → Fix Committed
Changed in keystone:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: liberty-3 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.