test_admin_version_v3 actually tests public app

Bug #1478504 reported by Alexey Miroshkin
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Alexey Miroshkin

Bug Description

VersionTestCase.test_admin_version_v3 (keystone/tests/unit/test_versions.py) in fact tests public app:

def test_admin_version_v3(self):
    client = tests.TestClient(self.public_app)

It makes sense only in case of V3 eventlet setup where public app handles both endpoints, but I believe it should be tested by a separate test like test_admin_version_v3_eventlet which will be introduced as part of fix of bug #1381961. Also this behavior was introduced when 2 apps setup was used for eventlet.

Changed in keystone:
assignee: nobody → Alexey Miroshkin (amirosh)
Revision history for this message
Dolph Mathews (dolph) wrote :

eventless == eventlet ?

description: updated
Changed in keystone:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/206472

Changed in keystone:
status: Triaged → In Progress
Revision history for this message
Alexey Miroshkin (amirosh) wrote :

Yes, eventless == eventlet, an autocorrect issue, thanks for noticing, fixed.

description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/206472
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=5b6296849346f907a08bd161e6536d74825d315c
Submitter: Jenkins
Branch: master

commit 5b6296849346f907a08bd161e6536d74825d315c
Author: Alexey Miroshkin <email address hidden>
Date: Tue Jul 28 03:29:18 2015 -0700

    Test admin app in test_admin_version_v3

    This fix enables testing of admin app in test_admin_version_v3 as
    test name suggests. The test itself remains skipped in this fix because
    it depends on fix of a bug #1381961 which can't be properly tested
    without this one.

    Change-Id: I1b014506b1c83eb309991a6e581f9ef4189e0f2d
    Closes-Bug: #1478504

Changed in keystone:
status: In Progress → Fix Committed
Changed in keystone:
milestone: none → liberty-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: liberty-2 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.