Testing of results of entity lists does not check that the command part of the url is in the 'self' link

[Alexey Miroshkin]

Methods assertValidListResponse and consequently assertValidListLinks of the unit test RestfulTestCase (test_v3.py) don't have any information about request, so the check of 'self' url in links collection is very general:

self.assertThat(links['self'], matchers.StartsWith('http://localhost'))

To implement a proper fix of the bug 1195037 ("Self" link in v3 collections omits any url filters) we need to pass some request data, at least the command part of the url, for example:

def assertValidListLinks(self, links, command=None)
def assertValidListResponse(self, resp, key, entity_validator, ref=None,
                                expected_length=None, keys_to_check=None,
                                command=None)

as result a proper check would be possible:

if command:
            self.assertThat(links['self'], matchers.EndsWith(command))

[Dolph Mathews (dolph)]

Henry: I try to save "Wishlist" for user-facing features, and use Low for dev-impact only things like refactors and small test coverage improvements.

Alexey: Was there a fix committed for this somewhere? Did it cite this bug number? Can you to link it here, or paste the git hash?

[Alexey Miroshkin (amirosh)]

Dolph: Yes, it was reviewed and committed https://review.openstack.org/#/c/109290/
The commit message contains Closes-Bug: #1348063

[Dolph Mathews (dolph)]

Ah, the bot must not have picked it up due to the period at the end. Thanks!