Regions resource should allow NULL description

[Jay Pipes]

Currently, the description column in the SQL driver's Region model is required. This is an optional attribute and should allow NULL values.

Fix is to add a migration that sets the description column to nullable.

[Dolph Mathews (dolph)]

Migration 37 has unique=True and nullable=False on the description column

[Lance Bragstad (lbragstad)]

related patch:

https://review.openstack.org/#/c/79159/

[Lance Bragstad (lbragstad)]

If we wanted to roll the nullable=False fix in, we could do it in the migration (043 https://review.openstack.org/#/c/79159/4/keystone/common/sql/migrate_repo/versions/043_fixup_region_description.py ) that I have up. Last Dolph and I spoke about it though, it was decided to keep it non nullable and carry the logic for the case where the user doesn't supply a description in the request in the manager https://review.openstack.org/#/c/78658/3/keystone/catalog/core.py

Just wanted to mention that in case it is decided that we should make the description column nullable.

[Dolph Mathews (dolph)]

I think nullable=True is fine, as long as we can make it optional in the API and default it to an empty string in the backend.

[Dolph Mathews (dolph)]

I meant nullable=False!

[Dolph Mathews (dolph)]

Apologies- the fix landed referencing a dupe, so I reversed the dupe status.