Creating a region using V3 api fails in backend code when missing description

[Lance Bragstad]

When creating a region using the V3 API, the request fails out in the backend code. This check should be handled in the controller/manager like it does for other resources (federation does this - https://github.com/openstack/keystone/blob/master/keystone/contrib/federation/controllers.py#L43-L44)

We could use the same functionality provided in https://github.com/openstack/keystone/blob/master/keystone/common/controller.py#L607 to fix this:

http://paste.openstack.org/show/69690/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/76444

[Lance Bragstad (lbragstad)]

Thinking this is a result of https://github.com/openstack/keystone/blob/master/keystone/common/sql/migrate_repo/versions/037_add_region_table.py#L27

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/78658

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/79159

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/79159
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=f4f25f64c622dbe6eb8f1e386430091a87b26fb2
Submitter: Jenkins
Branch: master

commit f4f25f64c622dbe6eb8f1e386430091a87b26fb2
Author: Lance Bragstad <email address hidden>
Date: Sat Mar 8 15:23:08 2014 +0000

    Fixup region description uniqueness

    Add a db migration for relaxing the uniqueness constraint on the
    'description' column in the region table.

    The migration will only occur if there is a unique index constraint
    on the 'description' table. The previous migration of 037 has
    had the unique index dropped on table creation. 043 will only be
    run in the case of a deployment tracking closer to master than
    the official releases.

    Related-Bug: 1284972
    Change-Id: I8198aec2fea4ff6a88938696499a60ebc0b16a47

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/78658
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=42b823a44767f5dd613e717b3ac119787189c397
Submitter: Jenkins
Branch: master

commit 42b823a44767f5dd613e717b3ac119787189c397
Author: Lance Bragstad <email address hidden>
Date: Thu Mar 6 16:19:09 2014 +0000

    Allow 'description' in V3 Regions to be optional

    Currently, description is required for POST requests to regions when
    using the SQL backend. According to the Identity V3 API spec,
    description is not required. If a user creates a region without
    specifying a description for the region in the request, we can make sure
    it is sent to the database as an empty string.

    Change-Id: Ia6fb1a2eee6b471c0c44a66590f53d061bcd8643
    Related-Bug: 1284972

[OpenStack Infra (hudson-openstack)]

Change abandoned by Lance Bragstad (<email address hidden>) on branch: master
Review: https://review.openstack.org/76444
Reason: This is being addressed using jsonschema here:

https://review.openstack.org/#/c/96266/

[David Stanek (dstanek)]

There are two related problems:

  - when the user passes a null value for description when creating
  - when the user passes a null value for description when updating