Comment 42 for bug 1202952

Revision history for this message
Morgan Fainberg (mdrnstm) wrote : Re: PKI tokens are never revoked using memcache token backend

Folsom - bug-1202952-folsom-v2.patch from comment #34
- unit tests worked - Ran 709 tests in 44.883s
- visual inspection looks good
- verified functionally in devstack
= abstain since I provided updated patch (+2 if this doesn't matter)

Grizzly - bug-1202952-grizzly-v1.patch from comment #29
- unit tests worked - Ran 1306 tests in 191.340s
- visual inspection - missing expires field in revocation list in memcache driver
- fails functionally in devstack (memcache driver causes exception in building revocation_list due to missing 'expires' key/element in the elements in the revocation_list)
= -2 (do not merge)

Updated grizzly bug-1202952-grizzly-v2.patch from comment #41
- Units test pass with the addition of netaddr in vnenv - Ran 1306 tests in 192.625s
- visual inspection looks good
- verified functionally in devstack (no exceptions)
= abstain since I provided updated patch (+2 if this doesn't matter)

Master patch from #7 does not apply.
error: patch failed: keystone/token/backends/memcache.py:174
error: keystone/token/backends/memcache.py: patch does not apply
- Patch from #7, while beneficial is not required for this bug. Master is not affected by the security bug.