Kernel SRU Workflow

  1. Series prepare-package
  2. Bug #1961191
  3. Comment #2

Comment 2 for bug 1961191

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

sru-review:

* meta, signed, lrm diffs are all mechanical version updates without any packaging changes

* lrm changelog missing the changelog from the +1 underspin, as expected (1024 abi was prepared prior to +1 underspin)

* kernel uses new firmware files that are only available in jammy

-firmware: bnx2x/bnx2x-e1-7.13.15.0.fw
-firmware: bnx2x/bnx2x-e1h-7.13.15.0.fw
-firmware: bnx2x/bnx2x-e2-7.13.15.0.fw
+firmware: bnx2x/bnx2x-e1-7.13.21.0.fw
+firmware: bnx2x/bnx2x-e1h-7.13.21.0.fw
+firmware: bnx2x/bnx2x-e2-7.13.21.0.fw

The module only declares dep on v21 firmware, but will fallback to load v15 firmware. However because it is not declared in the module, it will not be picked up by initramfs-tools to be included in the initrd for example. Thus these broadcom ethernet devices may loose networking in the initrd. The fix for this would be add MODULE_FIRMWARE() declarations for the v15 firmware, or to SRU linux-firmarew with the v21 firmware.

* ACPI, usb, security changes all look fine and small/correct.

* sru-review approved, however the firmware needs to be followed up with MODULE_FIRMWARE() declarations, or with linux-firmware SRU.