Comment 81 for bug 688576

Revision history for this message
In , A-samirh78 (a-samirh78) wrote :

Git commit 03bcb3d3ff89074a68839b6ebeb8030ef0ee4fd1 by Ahmad Samir, on behalf of David Faure.
Committed on 26/09/2020 at 13:34.
Pushed by ahmadsamir into branch 'master'.

kio_trash: remove unnecessarily strict permission check

Tested with `chmod 0770 /d/.Trash-1000` (where /d is a mount point),
kio_trash complained about security checks before this commit,
and works with it.

Also tested with a USB key which ends up mounted as
type vfat (rw,nosuid,nodev,relatime,uid=1000,gid=100,fmask=0022,dmask=0022,codepage=437,iocharset=iso8859-1,shortname=mixed,showexec,utf8,flush,errors=remount-ro,uhelper=udisks2). After kio_trash creates .Trash-1000
it complained about a "strange filesystem", and while this is still true :),
the removal of the code in TrashImpl::initTrashDirectory makes
the trash dir on the USB key usable.
FIXED-IN: 5.74

M +4 -21 src/ioslaves/trash/trashimpl.cpp

https://invent.kde.org/frameworks/kio/commit/03bcb3d3ff89074a68839b6ebeb8030ef0ee4fd1