Comment 25 for bug 596327

Revision history for this message
Chris Samuel (chris-csamuel) wrote :

Excellent work Joshua, the only change I had to make to your patch (in order to add it automatically to the build in the debian/patches directory) was to change the references from src/$file to a/src/$file for lines removed and b/src/$file for lines added. Look at exiv2-0.19/debian/patches/00_hyphens_used_as_minus.diff as an example. I also named it 01_nikon_exif.diff and added it to the series file in debian/patches to automate its application.

After rebuilding (and installing) the exiv2 packages and then rebuilding kdegraphics and installing the new libkexiv2-*.deb packages I was able to fire up digikam, shot some random images of my office and downloaded the images from the SD card of my D90 - much much faster!

Final proof that this patch works is redoing my previous tests with the exiv2 command on the same test image:

chris@quad:/tmp$ time exiv2 -M'set Exif.Image.Make NoName' DSC_0147.JPG

real 0m0.027s
user 0m0.000s
sys 0m0.020s

chris@quad:/tmp$ time exiv2 -M'set Exif.Image.Make NIKON CORPORATION' DSC_0147.JPG

real 0m0.016s
user 0m0.000s
sys 0m0.010s

chris@quad:/tmp$ time exiv2 -M'set Exif.Image.Make NoName' DSC_0147.JPG

real 0m0.027s
user 0m0.010s
sys 0m0.010s

I make that between 155x and 229x faster than the unpatched version!