Comment 6 for bug 360555

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Paul Everitt wrote:
> Regarding the right way to address these exceptions, I don't have much
> of a comment. Whatever you and Tres decide.
>
> --Paul
>
> On Apr 17, 2009, at 11:35 PM, Shane Hathaway wrote:
>
>> I get a lot of exceptions when I try to navigate this part of a site.
>> The exceptions happen because ISecurityWorkflow.setInitialState() is
>> not being called for some objects.

There *isn't* any workflow desired for those objects (inside the
intranet). I think I saw you check in a fix which made the
AttributeErrors go away, which should be fine for the intranet.

A better fix might be to move the workflow-centric UI elements into the
"layout" somehow, so that the check wouldn't even be done when in the
intranets.

>> We could clean this up by having the application use annotations
>> instead
>> of setting a magic attribute named 'security_state'. Also, we could
>> call setInitialState() from an event subscriber listening for
>> IObjectAddedEvent or IObjectCreatedEvent.

Annotations feel like over-engineering to me.

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 <email address hidden>
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJ7JDx+gerLs4ltQ4RAo00AKCwfawEiCHfJP2DkUtVMedr++zM2ACfdG2K
gzqPD6ffftL9RgJoqJTLk1M=
=3Fp3
-----END PGP SIGNATURE-----