Comment 3 for bug 1569786

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/19265
Committed: http://github.org/Juniper/contrail-vrouter/commit/0f8fb1c44c7526f0d742bb92ef8cd03f25f2028a
Submitter: Zuul
Branch: R3.0

commit 0f8fb1c44c7526f0d742bb92ef8cd03f25f2028a
Author: Divakar <email address hidden>
Date: Wed Apr 13 15:06:30 2016 +0530

Create a new flow if a packet hits a delete marked flow

When Agent deletes a flow, the flow entry is not immediately deleted in
Vrouter. Vrouter uses work queues and rcu callbacks to streamline the
deletion. After these asynchronous callbacks, flow entry is treated as
deleted. If there are any packets hitting this flow entry before marking
as "not active" those packets are dropped. On a loaded system with huge
number of flows, these call backs take a considerable time(in the worst
case as much as 30 ms). Packets hitting this flow entry will be dropped
for all this time.

To avoid this issue, when Agent deletes the flow entry, entry is "marked
deleted". A delete marked entry is no more treated as active entry,
hence flow lookup does not return this entry. As a result, a new flow
entry gets created. All the subsequent packets hit the new entry. "flow"
utility displays this particular entry as "Dm".

Change-Id: I0e150bbeb4b3fe3bf3fa1f367e074586363786f2
closes-bug: #1569786