Comment 10 for bug 1457243

Reviewed: https://review.opencontrail.org/10929
Committed: http://github.org/Juniper/contrail-controller/commit/6d845c15ca2bd114ded81d4092aa134b929ec39e
Submitter: Zuul
Branch: R2.20

commit 6d845c15ca2bd114ded81d4092aa134b929ec39e
Author: Nipa Kumar <email address hidden>
Date: Tue May 26 14:50:42 2015 -0700

Agent: XMPP connection not attempted by agent

Agent marks connection to Xmpp-Server DOWN after several attempts and rediscovers controllers.
If the controller list sent by Discovery is already marked DOWN, agent does not honor the
controller connection to be applied. This happens in the time period where discovery has not
yet marked the controller down (marked when 3 heartbeats are missing) and sends the stale list.
Additionally as discovery client has a checksum so the callbacks are throttled at source and
hence the clients never get called when controllers are UP and the information is lost.

Solution is to honor reponse from discovery irrespective of the state of the publisher
(both Xmpp Server advertised by controller and dns daemon)

Test cases added.

Change-Id: I5c6695f04d3dd4a384f0ea7d0da912475966c6eb
Closes-Bug:1446463
Closes-Bug:1457243