Comment 30 for bug 1556363

Reviewed: https://review.opencontrail.org/22313
Committed: http://github.org/Juniper/contrail-vrouter/commit/4928317cf1975fce73912935d9a6f02afbdf26fb
Submitter: Zuul
Branch: R3.1

commit 4928317cf1975fce73912935d9a6f02afbdf26fb
Author: Anand H. Krishnan <email address hidden>
Date: Fri Jul 22 10:11:36 2016 +0530

Do not create new flows for ICMP6 errors

Bug fix for 1556363 have reintroduced the issue of creating new flows
for ICMP errors. It looks like a cherry-pick/merge problem, since the
issue is present only in the mainline branch.

The process of forming the flow key is a recursive call for ICMP error,
since we look into the inner packet that caused the ICMP error. Once we
process the inner packet and form the flow key, we should return
immediately rather than continuing with the parent function, since the
parent will start using the ICMP error packet for formation of the flow
key.

Change-Id: I601886aeb3fa4a50a057f2c982f8c7b19dd7e3d1
Closes-Bug: #1556363