Comment 21 for bug 1556363

Reviewed: https://review.opencontrail.org/21744
Committed: http://github.org/Juniper/contrail-vrouter/commit/354f7e27278b6565f39b3ae116442cd83bb355ad
Submitter: Zuul
Branch: master

commit 354f7e27278b6565f39b3ae116442cd83bb355ad
Author: Anand H. Krishnan <email address hidden>
Date: Thu Jul 7 16:30:49 2016 +0530

Do not create new flows for ICMP errors

Bug fix for 1556363 have reintroduced the issue of creating new flows
for ICMP errors. It looks like a cherry-pick/merge problem, since the
issue is present only in the mainline branch.

The process of forming the flow key is a recursive call for ICMP error,
since we look into the inner packet that caused the ICMP error. Once we
process the inner packet and form the flow key, we should return
immediately rather than continuing with the parent function, since the
parent will start using the ICMP error packet for formation of the flow
key.

Change-Id: I41c92ad44477c771e694661e625c39ff529bbe4a
Closes-BUG: #1556363