Comment 39 for bug 1778671

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/44314
Committed: http://github.com/Juniper/contrail-windows-docker-driver/commit/ad77e134aea7761bc005f8f622d239ea71014f6f
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit ad77e134aea7761bc005f8f622d239ea71014f6f
Author: Michal Kostrzewa <email address hidden>
Date: Tue Jul 3 13:19:02 2018 +0200

Refactor out CreateEndpoint method.

CreateEndpoint touches many different parts of the codebase, so the
refactors are surprisingly extensive.

* Create a facade for Controller to try and shrink the Controller port
interface. It's still WIP (needs to be done gradually when refactoring
other handlers), but I belive it's a step in the right direction.
* Refactor CreateEndpoint by simplifying the way it calls its
collaborators. Move it to driver_core package.
* Fixed fake controller implementation by using
contrail-go-api Interceptors to mimic the actual API server behaviour of
assigning Default GW, MAC and IPs. This accidentally fixed two
controlelr_test.go tests. Oops.

Change-Id: I8a4f9dbdd390f7167409689cd2ae6c204b0a3edb
Partial-Bug: #1778671