Comment 43 for bug 1463208

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/14329
Committed: http://github.org/Juniper/contrail-server-manager/commit/d0cb087e5d676b5900bfb5b2c4c1aa2f79f844cc
Submitter: Zuul
Branch: R2.22-dev

commit d0cb087e5d676b5900bfb5b2c4c1aa2f79f844cc
Author: nitishkrishna <email address hidden>
Date: Thu Oct 8 20:11:55 2015 -0700

Related-Bug: #1463208 - Bug fixes for Cliff Client based on Testing [1]

This check-in has bug fixes for following bugs filed by Ritam:

- From SM client cli expansion/options don’t show up after ‘delete/display server -<tab>’ or ‘delete/display server --<tab>’.
- Server-manager-client delete server --where <where clause> , this gives ‘Match key not present’ error.
- Where clause doesn’t work for cluster deletion, same issue as no 5 above.
- In case of empty list display I see SM client cli and shell throwing a error “list index out of range”. Don’t see this happening when I use the -d option.
- Server-manager-client status server –detail/-d ---- I feel this option should be removed as there is nothing to display in detail over here.
- Mac id or id mandatory for modify
- Add tag/ Update tag (server-manager-client add/update tag --tags tag1=abc.tag2=cdf) -> JSON NOT TESTED
- Add server <enter> asks to specify the id to edit the object. Please change the message to say specify id to add the object.
- Add server --id <server_id> <tab> does not show the parameters.
- I feel these parameters should not be made mandatory. Without these server addition fails. cluster_id, password

Additional features:
- (server-manager-client) add server -f /root/sm_file >>>>>>>>>>>>> Path doesn’t auto complete. Absolute paths should auto complete from the cli shell as well.
- While in the cli shell on a tab it shows all the available command options like display add delete etc. There should be a mention of q/quit/exit as the shell exit option as well.
- tab-completion of image/package in reimage/provision command - name comes after option given: reimage/provision --cluster_id abc [TAB] : shows image_id/package_id respectively.

Change-Id: I5727ced3b4e6e9508318b3365ad14c6ab04ffb1b