Comment 5 for bug 1425718

Reviewed: https://review.opencontrail.org/8877
Committed: http://github.org/Juniper/contrail-puppet/commit/42aa0dcd66d1501b88595175cde85c3441c0377b
Submitter: Zuul
Branch: master

commit 42aa0dcd66d1501b88595175cde85c3441c0377b
Author: root <email address hidden>
Date: Thu Apr 2 19:36:47 2015 -0700

SM-Storage: Fix multiple bug of sm-storage (mentioned below)

Closes-Bug: #1430476
ISSUE: On reboot of compute node, livemnfsvol was not mounted and
live-migration failed
ROOT-CAUSE: sm-storage was adding a entry into /etc/fstab for nfs.
previosuly puppet used to run all times, it will remount the livemnfsvol
After R2.1, puppet stopped running after provisioning, it was uncovered
FIX:
1. added entry to /etc/fstab
2. Changed live-migration script to make use of data network ip of
live-migration-nfs-host instead getting ip from host command
TESTING: After provision completion, verfied mount is available again.

Closes-Bug: #1439401
ISSUE: if live-migration is not configured but chassis is configured,
puppet agent reports of missing resource
FIX: Added a condition for adding dependency for chassis->live-migraion
TESTING: configured cluster without live-migration and with chassis, verfied
that no error are reported

Closes-Bug: #1436596
ISSUE: Sometimes storage installation is failed and reports "dpkg --configure -a"
should be run mannually to allow installation to go through
ROOT-CAUSE: There could be a case, where compute is reported as successfull,
but still one or more statements failed in compute role and disallow
reboot to run. This caused compute role to create
/etc/contrail/interface_created with contents "2" and give wrong
impression to storage that system has rebooted. Storeage starts
installation of packages, but in the middle of it, system reboots and
causes above issue.
FIX: moved created of /etc/contrail/interface_created from compute to storage
TETSING: reimaged/provisioned the cluster 5-6 times, no issue was reported

Closes-Bug: #1425718
Closes-Bug: #1439460
ISSUE: Certain times livemnfs instance may not come-up and report error. This
causes mount to fail on compute nodes.
Sometimes, even if livemnfs VM comes-up, mount may still fail, this
may happen if VM is not able fetch http://169.254.169.254/latest/user-data
and internal script waits there for rebooting by external force.
FIX: Added a check in live-migration script @openstack-role for mount, if mount
fails, stop the livemnfs instance and start again
TESTING: checked from openstack logs, mount code was hitting and instance was
stopped and started

Change-Id: Ieaa7f5015d18e59b8a5d31fa26d660ad8d6a9878