Comment 3 for bug 2034206

Revision history for this message
Alex Lutay (taurus) wrote :

I confirm, the "revision" files inside the "mysql_r188.charm" is "0".
It is actually zero inside all charms I have checked, constantly.

John, please correct my investigation:
 * long-long time ago Juju was generating both "version" (Git hash) and "revision". [1]
 * during migration to charmcraft, that functionality got lost. [2]

Your position: charmcraft/charmhub should generate file "revision" properly (non-zero). Correct?

[1]
https://github.com/juju/charm/blob/master/charmdir.go#L258C1-L260C3
https://github.com/juju/charm/blob/5fe646695e8585e7a6b9fedb0d10cc7fbc598e48/charmdir.go#L521
https://github.com/juju/charm/blob/master/charmbase.go#L66-L72

[2] https://github.com/canonical/charmcraft/issues/37