Comment 10 for bug 1671733

Revision history for this message
Anastasia (anastasia-macmood) wrote :

This is a very interesting case and is highlighting a few issues with the implementation.

For one, when removing machines 'destroy-model' actually force removes them (unless the machines are manual). This, in itself, may cause all sort of undesirable issues since the machines and their units (and consequently relations, applications, etc) are not given a chance to terminate properly.

The fix here has 2 parts.

Part 1:
Now that we do have --force option for 'destroy-model', we should only force remove non-manual machines when --force is desired for the model. Manual machine treatment will remain the same. The implications of this change would be a bit of a double-edged sword: on one hand, the machines will be given a chance to be terminated properly and harvest mode will be respected; on the other hand, this will definitely impact on how quickly models will be destroyed.

Part 2:
This all implies that force removal of machines does not respect harvest mode. We should rectify that.