Comment 10 for bug 1600301

Revision history for this message
William Reade (fwereade) wrote :

@axwalk

1) In general, I'd love to extract that dependency... but it should really be "fix every worker that creates its own environ", otherwise we'll just see the same problems popping up elsewhere. (why does the firewaller work? perhaps the dummy provider doesn't do firewalls?) In short: yes, we should do that, but that helps with provisioner unit tests a lot more than it does with agent integration tests.

2) In this precise context, we'd still be injecting it from quite a significant distance. Is it much of a win over, say, patching environs.New? Not that I *want* to do that, but...